Moving callback firing code into its own method.#6
Merged
hobnob merged 1 commit intohobnob:masterfrom Oct 22, 2013
Merged
Conversation
Owner
|
@jamesmoss Cool, looks nice. Thanks! :-) |
hobnob
added a commit
that referenced
this pull request
Oct 22, 2013
Moving callback firing code into its own method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've just refactored the
endmethod, pulling out the code that creates aSimpleXMLElementand callscall_user_func_arrayinto it's own method namedfireCallbacks.My use case for this is that I want to use
xmlStreamReaderto count the number of times a path is matched in large XML docs. Speed is important so I don't want the overhead of creating aSimpleXMLElementobject and callingcall_user_func_arrayeverytime a path is matched. In my own class I'm planning to extendParserand overridefireCallbacksto increment a counter var instead.