AD buoyancy: minor modification of SolveOption1 algorithm#2
Merged
hkross merged 3 commits intohkross:feature/Buoyancyfrom Jan 18, 2022
Merged
AD buoyancy: minor modification of SolveOption1 algorithm#2hkross merged 3 commits intohkross:feature/Buoyancyfrom
hkross merged 3 commits intohkross:feature/Buoyancyfrom
Conversation
The ED%Input(1)%HubPtLoad was being changed in both solve option1 and solve option2.
It isn't actually a problem that the meshcopy might take place twice. Rather than add a bunch of logic around one of the `MeshCopy( ED%Input(1)%HubPtLoad, MeshMapData%u_ED_HubPtLoad, MESH_NEWCOPY, ErrStat2, ErrMsg2 )` calls, we'll just let it occur twice if we happent to MHK and solve option 1 both enabled.
5 tasks
hkross
pushed a commit
that referenced
this pull request
Jan 31, 2022
Forgot to remove an override of the position for the Nacelle mesh in PR OpenFAST#982.
hkross
pushed a commit
that referenced
this pull request
Apr 14, 2023
Lidar for IfW updates/modifications
hkross
pushed a commit
that referenced
this pull request
Jun 6, 2023
openfast(66108,0x10fb1edc0) malloc: *** error for object 0x7fe4a223a000: pointer being freed was not allocated openfast(66108,0x10fb1edc0) malloc: *** set a breakpoint in malloc_error_break to debug Program received signal SIGABRT: Process abort signal. Backtrace for this error: \#0 0x103a3f33d \#1 0x103a3e76d \#2 0x7fff68c225fc Abort trap: 6
hkross
pushed a commit
that referenced
this pull request
Jun 6, 2023
HydroDyn/SeaState Code Cleanup + Registry updates
hkross
pushed a commit
that referenced
this pull request
Aug 13, 2024
Update to dev branch, and include regression test updates
hkross
pushed a commit
that referenced
this pull request
Aug 13, 2024
ADI_C: minor name changes, a couple of notes for future
hkross
pushed a commit
that referenced
this pull request
Aug 13, 2024
MD: remove extra internal read for linear damping on rods
hkross
pushed a commit
that referenced
this pull request
Sep 5, 2025
FAST_CreateCheckpoint expects a fixed sized char buffer of size 1025:
`CHARACTER(KIND=C_CHAR), INTENT(IN ) ::
CheckpointRootName_c(IntfStrLen)`. However the c++ is taking a 1 char
string and sending a pointer to that data to the Fortran. The Fortran
`TRANSFER` function then throws a good old:
```
==2684227==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x5120002144e8 at pc 0x557e98358a61 bp 0x7ffc0f87ea90 sp 0x7ffc0f87e248
READ of size 1025 at 0x5120002144e8 thread T0
#0 0x557e98358a60 in memcpy /mnt/vdb/home/jrood/goose/spack/var/spack/stage/spack-stage-llvm-17.0.6-fzo52dlnsdgyyb3wgxrrlxmnvepk6esa/spack-src/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors_memintrinsics.inc:115:5
#1 0x7f0d5b25c311 in FAST_CreateCheckpoint /mnt/vdb/home/mhenryde/exawind/exawind-manager/environments/nalu-wind-dev/openfast/modules/openfast-library/src/FAST_Library.f90:445:76
#2 0x7f0d5f5ea22e in fast::OpenFAST::step(bool)
/mnt/vdb/home/mhenryde/exawind/exawind-manager/environments/nalu-wind-dev/openfast/glue-codes/openfast-cpp/src/OpenFAST.cpp:1436:17
```
This PR fixes this error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ED%Input(1)%HubPtLoad was being changed in both solve option1 and solve option2.
This seems to now be working with the BD land regression test.
The two MHK specific test cases run, but I have not checked the validity of those results.