Skip to content

Conversation

@n-takumasa
Copy link
Contributor

@n-takumasa n-takumasa commented Jun 12, 2025

  • Fix CLI
    • Added the missing [project.scripts] section in pyproject.toml.
    • Ensured that the script entry point refers to a valid function that can be executed.
  • Fix CI
    • pytest>=8.4.0, test must return None
  • Fix Docs
  • Executed pre-commit run --all-files with no errors
  • [N/A] The change is fully covered by automated unit tests
  • [N/A] Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

@n-takumasa
Copy link
Contributor Author

https://docs.pytest.org/en/stable/changelog.html#pytest-8-4-0-2025-06-02

pytest-dev/pytest#12346: Tests will now fail, instead of raising a warning, if they return any value other than None.

@n-takumasa n-takumasa changed the title fix: pint-convert fix: CLI, CI, Docs Jun 16, 2025
@andrewgsavage
Copy link
Collaborator

Thanks for doing this, it's appreciated. I haven't had a chance to look at it properly yet.

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 25, 2025

CodSpeed Performance Report

Merging #2178 will not alter performance

Comparing n-takumasa:master (a07ae04) with master (db02470)

Summary

✅ 447 untouched benchmarks
🆕 1 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 test_import N/A 655.3 µs N/A

@andrewgsavage
Copy link
Collaborator

Could you go back to d70d1b9, before the ruff changes that affect many files?
I think the ruff changes should be in another PR and could use some discussion. the last PR looking at ruff is still open and @hgrecco didn't want to use all settings yet. #1893

@n-takumasa
Copy link
Contributor Author

n-takumasa commented Jun 26, 2025

I agree and done :)

@andrewgsavage andrewgsavage merged commit c5a032b into hgrecco:master Jun 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix documenation error

2 participants