Skip to content

fix: modify the statement of validate semantic model sql to make its validation more comprehensive #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junjiem merged 2 commits into from
Nov 19, 2025
+2 −1
Merged

fix: modify the statement of validate semantic model sql to make its validation more comprehensive #146

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56dd091
fix: modify the statement of validate semantic model sql to make its …
junjiem Nov 19, 2025
c047bb0
fix: modify the statement of validate semantic model sql to make its …
junjiem Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dat-sdk/src/main/java/ai/dat/boot/PreBuildValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,8 @@ private ValidationMessage validateSemanticModelSql(@NonNull DatabaseAdapter data
log.warn("Semantic model sql parse exception, Model SQL: " + semanticModel.getModel(), e);
return new ValidationMessage(semanticModel.getName(), e);
}
String sql = "SELECT 1 FROM (" + semanticModelSql + ") AS __dat_semantic_model WHERE 1=0";
String quotedName = semanticAdapter.quoteIdentifier(semanticModel.getName());
String sql = "WITH " + quotedName + " AS (" + semanticModelSql + ") SELECT 1 FROM " + quotedName + " WHERE 1=0";
try {
databaseAdapter.executeQuery(sql);
} catch (SQLException e) {
Expand Down