Conversation
|
Hello. Thank you for your contribution! Also, thank you for adding unit tests for your contribution. Both are much appreciated. Good catch on the error too, this is something we clearly missed locally. We will need you to sign a Contributor Assignment Agreement (CAA) and email it to cla@hdoc.io so that this can be merged into our repository. This is unfortunately necessary for legal reasons. I have attached the CAA to this comment. Thank you! |
Clang 14 crashes if getParamNameAsWritten() is called without first checking whether it exists.
|
Thank you for completing the CLA promptly and sending it over. We have received it. Your changes will be merged in to our upstream hdoc repo (which is private) and when we make a new release the changes will be reflected on GitHub. We’re targeting this changes for hdoc 1.3.1, which is the next release. Thank you for finding and fixing this bug and submitting a good PR, even with unit tests! We will credit you in the release notes for the next release. Thank you and have a good week. |
|
Hello @totph, your fix has been incorporated in hdoc 1.3.1 which we just released. We have credited you in the release notes, which can be found here: https://hdoc.io/release-notes/#version-1-3-1-29-september-2022. In addition, we've credited you for the variety of suggestions and bugs you've reported recently. Thank you for your invaluable feedback! |
Clang 14 crashes if getParamNameAsWritten() is called without
first checking whether it exists.