Journey Theme: fixing the window size when tray is collapsed #760
+49
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chloemartin312 is attempting to deploy a commit to the HAXTheWeb Team on Vercel. A member of the Team first needs to authorize it. |
btopro
requested changes
Jan 23, 2026
Member
btopro
left a comment
btopro
left a comment
There was a problem hiding this comment.
The 2 files in question I don't think require these changes. Remove the changes and test locally. Also test in themes not journey to see if there are other themes that need to apply this improvement in screen resizing
elements/hax-body/hax-body.js
Outdated
| opacity: 0.2; | ||
| pointer-events: none; | ||
| } | ||
| :host([edit-mode][tray-status="collapsed"]) { |
elements/hax-body/lib/hax-tray.js
Outdated
| } | ||
| :host([edit-mode][collapsed]) .wrapper { | ||
| width: unset; | ||
| width: 0; |
Member
There was a problem hiding this comment.
The tray gets moved off screen so I'm not sure this is useful
btopro
reviewed
Jan 23, 2026
| :host([edit-mode][collapsed]) .wrapper { | ||
| width: unset; | ||
| } | ||
Member
There was a problem hiding this comment.
this shouldnt be removed entirely. it should be
:host([edit-mode][collapsed]) .wrapper {
width: unset;
}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the blocks or configure tray is collapsed, the body takes up the whole screen.
haxtheweb/issues#2551