Lightning example for CoxPH loss#78
Open
rohanshad wants to merge 10 commits intohavakv:refactor_out_torchtuplesfrom
Open
Lightning example for CoxPH loss#78rohanshad wants to merge 10 commits intohavakv:refactor_out_torchtuplesfrom
rohanshad wants to merge 10 commits intohavakv:refactor_out_torchtuplesfrom
Conversation
…equirements.txt
Co-authored-by: Haavard Kvamme <haavard.kvamme@abelee.com>
Merge remote-tracking branch 'upstream/refactor_out_torchtuples' into lightning_example
Pull latest changes
Owner
|
Great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal example of CoxPH loss working with pytorch lightning in
lightning_coxph.py.I've separately built this into my other scripts with integration within the torch lightning test step logic for easier logging. I decided not to do that here since that requires dataset specific transformations / logging with tensorboard.Made some other small changes to docstrings too.