-
Notifications
You must be signed in to change notification settings - Fork 21
Fix/325 voting statistics display #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Agamya-Samuel
wants to merge
4
commits into
hatnote:master
Choose a base branch
from
Agamya-Samuel:fix/325-voting-statistics-display
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix/325 voting statistics display #369
Agamya-Samuel
wants to merge
4
commits into
hatnote:master
from
Agamya-Samuel:fix/325-voting-statistics-display
+172
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahmoud
reviewed
Jan 29, 2026
Member
mahmoud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Would you mind including a recording of it in action? Just a screen recording of your local is fine.
Author
|
Sure @mahmoud |
Author
Before
2026-01-28.23-53-30.mp4AfterYes/No Vote:2026-01-29.01-55-05.mp4Rating Vote:2026-01-29.01-45-21.mp4 |
Only return voting statistics when show_stats is enabled for the round. This prevents statistics from being returned when the feature is disabled.
- Add statistics display section showing Accept/Decline counts - Implement statistics fetching on mount and round prop changes - Refresh statistics automatically after each vote submission - Add CSS styles for statistics display
- Add statistics display section showing star ratings distribution (1-5 stars) - Implement statistics fetching on mount and round prop changes - Refresh statistics automatically after each vote submission - Add CSS styles for statistics display
Improve vertical alignment of star icons in the statistics section by using inline-flex with center alignment for better visual consistency.
f2aa510 to
1657280
Compare
Author
|
Hi @mahmoud the PR is ready to be reviewed. I have attached the requested video recording. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix voting statistics display issue #325