Make genericSerial generic over Integral #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmicklas
reviewed
Jan 10, 2021
thomasjm
force-pushed
the
generic-serial
branch
2 times, most recently
from
58d3486 to
3e2da4e
Compare
Contributor
Author
|
Hi @LaurentRDC, I was hoping you could take a look at this as well. This was an old PR, where I've just responded to all of @kmicklas's comments. |
Member
|
Thanks, I got all the notifications ;) This is a breaking change, and we've been accumulating them for an impending 0.11 release. I'll need to check with Travis because there were other PRs he wanted to get in. I'll update this PR to point to the 0.11 branch. You'll need to rebase |
4 tasks
Contributor
Author
|
Rebase done! |
Member
|
Thanks! I just rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested on #532