-
Notifications
You must be signed in to change notification settings - Fork 110
GEN-200: Set MSRV for error-stack to v1.83
#5333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # libs/error-stack/README.md # libs/error-stack/build.rs # libs/error-stack/macros/README.md # libs/error-stack/src/lib.rs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5333 +/- ##
==========================================
+ Coverage 20.23% 21.33% +1.10%
==========================================
Files 508 508
Lines 17260 17611 +351
Branches 2537 2537
==========================================
+ Hits 3492 3757 +265
- Misses 13730 13816 +86
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark results
|
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1
|
Flame Graph |
representative_read_entity_type
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| get_entity_type_by_id | Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579
|
Flame Graph |
scaling_read_entity_complete_zero_depth
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| entity_by_id | 50 entities | Flame Graph | |
| entity_by_id | 10 entities | Flame Graph | |
| entity_by_id | 25 entities | Flame Graph | |
| entity_by_id | 1 entities | Flame Graph | |
| entity_by_id | 5 entities | Flame Graph |
scaling_read_entity_linkless
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| entity_by_id | 1000 entities | Flame Graph | |
| entity_by_id | 100 entities | Flame Graph | |
| entity_by_id | 10 entities | Flame Graph | |
| entity_by_id | 10000 entities | Flame Graph | |
| entity_by_id | 1 entities | Flame Graph |
representative_read_multiple_entities
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| entity_by_property | depths: DT=2, PT=2, ET=2, E=2 | Flame Graph | |
| entity_by_property | depths: DT=255, PT=255, ET=255, E=255 | Flame Graph | |
| entity_by_property | depths: DT=0, PT=0, ET=0, E=0 | Flame Graph | |
| entity_by_property | depths: DT=0, PT=0, ET=0, E=2 | Flame Graph | |
| entity_by_property | depths: DT=0, PT=2, ET=2, E=2 | Flame Graph | |
| entity_by_property | depths: DT=0, PT=0, ET=2, E=2 | Flame Graph | |
| link_by_source_by_property | depths: DT=2, PT=2, ET=2, E=2 | Flame Graph | |
| link_by_source_by_property | depths: DT=255, PT=255, ET=255, E=255 | Flame Graph | |
| link_by_source_by_property | depths: DT=0, PT=0, ET=0, E=0 | Flame Graph | |
| link_by_source_by_property | depths: DT=0, PT=0, ET=0, E=2 | Flame Graph | |
| link_by_source_by_property | depths: DT=0, PT=2, ET=2, E=2 | Flame Graph | |
| link_by_source_by_property | depths: DT=0, PT=0, ET=2, E=2 | Flame Graph |
scaling_read_entity_complete_one_depth
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| entity_by_id | 50 entities | Flame Graph | |
| entity_by_id | 10 entities | Flame Graph | |
| entity_by_id | 25 entities | Flame Graph | |
| entity_by_id | 1 entities | Flame Graph | |
| entity_by_id | 5 entities | Flame Graph |
indietyp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, minor question
| #[expect( | ||
| clippy::manual_try_fold, | ||
| reason = "false-positive, try_fold is fail-fast, our implementation is fail-slow" | ||
| )] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking: do we want to make use of our new traits in this example? or not because they're unstable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't use them, yet, as they are unstable and examples are meant to be consumed.
🌟 What is the purpose of this PR?
Rust 1.83 enables a bunch of new features (we're currently on
1.63and a lot has been added since then)🔍 What does this change?
1.83Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
🐾 Next steps
Contextin favor ofcore::error::Erroronce-cellin favor ofstd::sync::LazyLock