Skip to content

Conversation

@TimDiekmann
Copy link
Member

@TimDiekmann TimDiekmann commented Jul 12, 2024

🌟 What is the purpose of this PR?

Two new features were added:

In particular, #4678 is interesting to track down a bug we're internally facing at HASH.

🔍 What does this change?

  • Make sure error-stack is compatible with Rust 1.63
  • Remove deprecated functionality
  • Bump version to 0.5.0
  • Add a --no-verify to the publish job. Verifying is currently broken because error-stack sees the workspace config of edition2024, but it does not use it.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • modifies a Cargo-publishable library and I have amended the version

📜 Does this require a change to the docs?

The changes in this PR:

  • require changes to docs which are made as part of this PR

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

@github-actions github-actions bot added area/infra Relates to version control, CI, CD or IaC (area) area/libs > error-stack Affects the `error-stack` crate (library) area/libs Relates to first-party libraries/crates/packages (area) labels Jul 12, 2024
@github-actions github-actions bot added area/deps Relates to third-party dependencies (area) area/tests New or updated tests labels Jul 12, 2024
@TimDiekmann TimDiekmann requested a review from indietyp July 12, 2024 12:33
@codecov
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 20.08%. Comparing base (323e8cc) to head (edd49df).
Report is 1859 commits behind head on main.

Files with missing lines Patch % Lines
libs/error-stack/src/report.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4706      +/-   ##
==========================================
+ Coverage   19.99%   20.08%   +0.08%     
==========================================
  Files         459      459              
  Lines       15832    15876      +44     
  Branches     2415     2419       +4     
==========================================
+ Hits         3166     3188      +22     
- Misses      12625    12647      +22     
  Partials       41       41              
Flag Coverage Δ
apps.hash-ai-worker-ts 1.48% <ø> (-0.01%) ⬇️
apps.hash-api 0.00% <ø> (ø)
blockprotocol.type-system 47.41% <ø> (ø)
deer 26.66% <ø> (ø)
error-stack 76.05% <75.00%> (-0.26%) ⬇️
local.hash-backend-utils 4.25% <ø> (ø)
local.hash-isomorphic-utils 0.00% <ø> (ø)
local.hash-subgraph 24.87% <ø> (ø)
sarif 89.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

Benchmark results

@rust/graph-benches – Integrations

representative_read_multiple_entities

Function Value Mean Flame graphs
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$1.93 \mathrm{s} \pm 6.90 \mathrm{ms}\left({\color{gray}-1.852 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$1.01 \mathrm{s} \pm 5.09 \mathrm{ms}\left({\color{gray}-2.484 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$1.01 \mathrm{s} \pm 3.10 \mathrm{ms}\left({\color{gray}-0.505 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$38.5 \mathrm{ms} \pm 235 \mathrm{μs}\left({\color{gray}-4.107 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$394 \mathrm{ms} \pm 1.53 \mathrm{ms}\left({\color{gray}-2.547 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$74.7 \mathrm{ms} \pm 472 \mathrm{μs}\left({\color{gray}-2.816 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$2.82 \mathrm{s} \pm 5.83 \mathrm{ms}\left({\color{gray}-0.902 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$964 \mathrm{ms} \pm 3.20 \mathrm{ms}\left({\color{gray}-3.379 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$985 \mathrm{ms} \pm 10.4 \mathrm{ms}\left({\color{gray}-0.375 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$37.0 \mathrm{ms} \pm 211 \mathrm{μs}\left({\color{gray}2.32 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$361 \mathrm{ms} \pm 1.72 \mathrm{ms}\left({\color{gray}-2.107 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$42.3 \mathrm{ms} \pm 218 \mathrm{μs}\left({\color{gray}2.69 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 100 entities $$2.03 \mathrm{ms} \pm 10.4 \mathrm{μs}\left({\color{gray}-0.382 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$1.84 \mathrm{ms} \pm 7.04 \mathrm{μs}\left({\color{gray}0.901 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.83 \mathrm{ms} \pm 6.94 \mathrm{μs}\left({\color{gray}1.62 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$2.77 \mathrm{ms} \pm 11.2 \mathrm{μs}\left({\color{gray}0.670 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$13.2 \mathrm{ms} \pm 139 \mathrm{μs}\left({\color{gray}2.09 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$1.40 \mathrm{ms} \pm 6.68 \mathrm{μs}\left({\color{gray}0.364 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 25 entities $$77.3 \mathrm{ms} \pm 364 \mathrm{μs}\left({\color{red}10.0 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$24.4 \mathrm{ms} \pm 338 \mathrm{μs}\left({\color{gray}2.47 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$1.56 \mathrm{s} \pm 11.0 \mathrm{ms}\left({\color{gray}2.37 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$50.2 \mathrm{ms} \pm 184 \mathrm{μs}\left({\color{red}12.9 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$19.6 \mathrm{ms} \pm 89.1 \mathrm{μs}\left({\color{gray}-0.720 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 25 entities $$2.61 \mathrm{ms} \pm 15.1 \mathrm{μs}\left({\color{lightgreen}-5.210 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$1.89 \mathrm{ms} \pm 11.4 \mathrm{μs}\left({\color{gray}0.262 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$3.92 \mathrm{ms} \pm 19.4 \mathrm{μs}\left({\color{lightgreen}-5.215 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.02 \mathrm{ms} \pm 12.3 \mathrm{μs}\left({\color{gray}-2.539 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.86 \mathrm{ms} \pm 9.90 \mathrm{μs}\left({\color{gray}1.28 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$15.6 \mathrm{ms} \pm 217 \mathrm{μs}\left({\color{gray}-3.897 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$15.1 \mathrm{ms} \pm 181 \mathrm{μs}\left({\color{lightgreen}-5.433 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$16.3 \mathrm{ms} \pm 238 \mathrm{μs}\left({\color{gray}1.74 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$17.1 \mathrm{ms} \pm 221 \mathrm{μs}\left({\color{red}5.18 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$16.6 \mathrm{ms} \pm 199 \mathrm{μs}\left({\color{lightgreen}-33.101 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$16.2 \mathrm{ms} \pm 163 \mathrm{μs}\left({\color{gray}2.14 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$16.5 \mathrm{ms} \pm 207 \mathrm{μs}\left({\color{gray}4.15 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$16.3 \mathrm{ms} \pm 186 \mathrm{μs}\left({\color{gray}2.54 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$16.6 \mathrm{ms} \pm 219 \mathrm{μs}\left({\color{red}7.87 \mathrm{\%}}\right) $$ Flame Graph

@TimDiekmann TimDiekmann added this pull request to the merge queue Jul 12, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 12, 2024
@TimDiekmann TimDiekmann removed this pull request from the merge queue due to a manual request Jul 12, 2024
@TimDiekmann TimDiekmann added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit 79dbaf6 Jul 12, 2024
@TimDiekmann TimDiekmann deleted the t/gen-188-bump-error-stack-to-050 branch July 12, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/deps Relates to third-party dependencies (area) area/infra Relates to version control, CI, CD or IaC (area) area/libs > error-stack Affects the `error-stack` crate (library) area/libs Relates to first-party libraries/crates/packages (area) area/tests New or updated tests

Development

Successfully merging this pull request may close these issues.

3 participants