Skip to content

cli: improve autocompletions for ACL commands#27505

Open
tgross wants to merge 1 commit intomainfrom
autocomplete-improvements-acls
Open

cli: improve autocompletions for ACL commands#27505
tgross wants to merge 1 commit intomainfrom
autocomplete-improvements-acls

Conversation

@tgross
Copy link
Member

@tgross tgross commented Feb 13, 2026

Some commands are missing autocompletion flags for specific fields, have completions for flags that are deprecated or no longer exist, have the wrong predictor, or don't perform searches for argument completions for objects from state.

This is one of three batches of work to improve autocompletions, focusing on a set of ACL-related commands.

Generative AI disclosure: as part of an ongoing pilot, this changeset was mostly generated via Claude Code with the exception of touch-ups to use existing helper methods and clean up its terrible docstrings. Reviewed and tested manually, with commit description written by human for humans.

Ref: #27507
Ref: #27506

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
    • as this is a UX improvement, this was tested manually
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad product documentation, which is stored in the
    web-unified-docs repo. Refer to the web-unified-docs contributor guide for docs guidelines.
    Please also consider whether the change requires notes within the upgrade
    guide
    . If you would like help with the docs, tag the nomad-docs team in this PR.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Some commands are missing autocompletion flags for specific fields, have
completions for flags that are deprecated or no longer exist, have the wrong
predictor, or don't perform searches for argument completions for objects from
state.

This is one of three batches of work to improve autocompletions, focusing on a
set of ACL-related commands.

Generative AI disclosure: as part of an ongoing pilot, this changeset was mostly
generated via Claude Code with the exception of touch-ups to use existing helper
methods and clean up its terrible docstrings. Reviewed and tested manually, with
commit description written by human for humans.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant