Skip to content

Conversation

@nickpellant
Copy link

This allows rack-client to perform patch requests. If the code is acceptable to the core maintainers I'd like to get this merged & tagged so that I can submit a pull request to engineyard/ey_api_hmac for a version bump.

@halorgium
Copy link
Owner

@nickpellant seems good. I'll get master passing again. The new rspec 3 release has broken the build.

@nickpellant
Copy link
Author

@halorgium I think I know what the problem is, can push a fix to this PR for you?

@halorgium
Copy link
Owner

@nickpellant would you be able to push a new PR getting master green?
I had some other issues:

@nickpellant
Copy link
Author

@halorgium The build passed: https://travis-ci.org/halorgium/rack-client/jobs/34722494

Not sure why it's coming through as not complete on here.

@nickpellant
Copy link
Author

Looking at the build @halorgium it's failing due to the test suite being run against JRuby and RBX.

@halorgium
Copy link
Owner

@nickpellant ah, I see you've pushed your PATCH to your master branch.
I generally try to have my forks exactly track the upstream, so if situations like this arise, I can branch off of a clean slate.

I'd like to get the tests green again without your PATCH patch, for clarity.
Could you branch off of halorgium/rack-client@master, file a new PR and get the tests passing?

Thanks!

@nickpellant
Copy link
Author

@halorgium Take a look at #19 for work on fixing the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants