Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

Conversation

@ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 29, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

修复保存文章设置导致发布时间丢失的问题。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3080

Special notes for your reviewer:

测试方式:

  1. 创建若干文章。
  2. 返回到文章管理列表。
  3. 打开任意文章的设置。
  4. 检查发布时间是否回显,然后保存。
  5. 保存之后检查发布时间是否还存在。

Does this PR introduce a user-facing change?

修复 Console 端保存文章设置导致发布时间丢失的问题。

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 29, 2022
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and JohnNiang December 29, 2022 12:40
@vercel
Copy link

vercel bot commented Dec 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ✅ Ready (Inspect) Visit Preview Dec 29, 2022 at 0:41AM (UTC)

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 29, 2022
@ruibaby
Copy link
Member Author

ruibaby commented Dec 29, 2022

/cherry-pick release-2.0

@halo-dev-bot
Copy link

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.0 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
it works
image

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2022
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guqing
Copy link
Member

guqing commented Dec 29, 2022

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 29, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit a7341df into halo-dev:main Dec 29, 2022
@halo-dev-bot
Copy link

@ruibaby: #807 failed to apply on top of branch "release-2.0":

Applying: fix: saving an post causes the publish time to be lost
Using index info to reconstruct a base tree...
M	src/modules/contents/pages/components/SinglePageSettingModal.vue
M	src/modules/contents/posts/components/PostSettingModal.vue
Falling back to patching base and 3-way merge...
Auto-merging src/modules/contents/posts/components/PostSettingModal.vue
CONFLICT (content): Merge conflict in src/modules/contents/posts/components/PostSettingModal.vue
Auto-merging src/modules/contents/pages/components/SinglePageSettingModal.vue
CONFLICT (content): Merge conflict in src/modules/contents/pages/components/SinglePageSettingModal.vue
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: saving an post causes the publish time to be lost
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby ruibaby deleted the fix/post-publish-time-update branch December 29, 2022 13:15
f2c-ci-robot bot pushed a commit that referenced this pull request Dec 29, 2022
#### What type of PR is this?

/kind bug

#### What this PR does / why we need it:

修复保存文章设置导致发布时间丢失的问题。

see #807

#### Which issue(s) this PR fixes:

Fixes halo-dev/halo#3080

#### Special notes for your reviewer:

测试方式:

1. 创建若干文章。
2. 返回到文章管理列表。
3. 打开任意文章的设置。
4. 检查发布时间是否回显,然后保存。
5. 保存之后检查发布时间是否还存在。

#### Does this PR introduce a user-facing change?

```release-note
修复 Console 端保存文章设置导致发布时间丢失的问题。
```
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…ole#807)

#### What type of PR is this?

/kind bug

#### What this PR does / why we need it:

修复保存文章设置导致发布时间丢失的问题。

#### Which issue(s) this PR fixes:

Fixes halo-dev#3080

#### Special notes for your reviewer:

测试方式:

1. 创建若干文章。
2. 返回到文章管理列表。
3. 打开任意文章的设置。
4. 检查发布时间是否回显,然后保存。
5. 保存之后检查发布时间是否还存在。

#### Does this PR introduce a user-facing change?

```release-note
修复 Console 端保存文章设置导致发布时间丢失的问题。
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

打开文章设置导致发布时间丢失

4 participants