Fix AbstractLocalizableInterfaceCreator.genMethodDecl; Fixes #10205#10206
Open
axeluhl wants to merge 1 commit intogwtproject:mainfrom
Open
Fix AbstractLocalizableInterfaceCreator.genMethodDecl; Fixes #10205#10206axeluhl wants to merge 1 commit intogwtproject:mainfrom
axeluhl wants to merge 1 commit intogwtproject:mainfrom
Conversation
Member
|
This is definitely the right fix for this specific bug, but it also calls back to my request in the initial PR that we need more tests here. I don't personally use these Creator tools, but if I were to put myself in the place of someone who did, I think I'd want to see more tests to ensure this or other errors can't happen. At this time I'm inclined to say we should just revert the patch and re-land it when it is tested, rather than risk breakage in 2.13 for users - let it bake a little more first to be sure. Could you update your title/description of the PR to match what the template suggested - short concise title, descriptive commit message, ends with the "Fixes..." trailer? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the order of AbstractLocalizableInterfaceCreator.genMethodDecl arguments;
this reverses the arguments of genMethodDecl to their original order so that the single call matches the declaration again.
Fixes #10205