Skip to content

Fix AbstractLocalizableInterfaceCreator.genMethodDecl; Fixes #10205#10206

Open
axeluhl wants to merge 1 commit intogwtproject:mainfrom
SAP:main
Open

Fix AbstractLocalizableInterfaceCreator.genMethodDecl; Fixes #10205#10206
axeluhl wants to merge 1 commit intogwtproject:mainfrom
SAP:main

Conversation

@axeluhl
Copy link
Contributor

@axeluhl axeluhl commented Dec 5, 2025

Fixes the order of AbstractLocalizableInterfaceCreator.genMethodDecl arguments;
this reverses the arguments of genMethodDecl to their original order so that the single call matches the declaration again.

Fixes #10205

@niloc132
Copy link
Member

niloc132 commented Dec 5, 2025

This is definitely the right fix for this specific bug, but it also calls back to my request in the initial PR that we need more tests here. I don't personally use these Creator tools, but if I were to put myself in the place of someone who did, I think I'd want to see more tests to ensure this or other errors can't happen.

At this time I'm inclined to say we should just revert the patch and re-land it when it is tested, rather than risk breakage in 2.13 for users - let it bake a little more first to be sure.

Could you update your title/description of the PR to match what the template suggested - short concise title, descriptive commit message, ends with the "Fixes..." trailer?

@axeluhl axeluhl changed the title fix order of AbstractLocalizableInterfaceCreator.genMethodDecl arguments; fixes #10205 Fix AbstractLocalizableInterfaceCreator.genMethodDecl; Fixes #10205 Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possibly incorrect i18n interface generation after #10166

2 participants