Enhance logging for non-instantiable field types#10199
Open
axeluhl wants to merge 1 commit intogwtproject:release/2.12from
Open
Enhance logging for non-instantiable field types#10199axeluhl wants to merge 1 commit intogwtproject:release/2.12from
axeluhl wants to merge 1 commit intogwtproject:release/2.12from
Conversation
axeluhl
force-pushed
the
release/2.12
branch
from
b39ae68 to
2416a30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In relation to #10181 I think that logging fields that cause a negative decision about a type's instantiability should be logged as a warning. Here is a suggestion.