Skip to content

LocalizableLinkageCreatorTest, others aren't in a suite, is never run #10258

@niloc132

Description

@niloc132

Not an exhaustive check, but more than half of the non-trivial packages i've sampled are missing tests from suites

i18n

shared

LocalizableLinkageCreatorTest - passes
TypeOracleMessageTest - this at least has a TODO asking for it to be restored, probably could just have a better classpath set up for it. Passes
BidiFormatterBaseTest - passes
SafeHtmlBidiFormatterTest - passes

client

LocaleInfo_en_Test - passes

Related: DateTimeFormatTestBase should be in client, not shared

request factory

ClassComparatorTest - passes

bindery events

UmbrellaExceptionTest - passes
HandlerRegistrationsTest - passes
CountingEventBusTest - passes. Is somewhat slow, one method loops through Integer.MAX_VALUE iterations

uibinder

UiBinderNameConflictsTest - passes
UiTextInterpreterTest - passes
UiSafeHtmlInterpreterTest - FAILS, looks like the order of the test methods matters, but testHappy runs first instead of last and fails due to a static int in Tokenator.
HasAlignmentParserTest - original author got a little cute with the javadoc after copy/pasting too many times, but it does at least pass, just missing from the suite

VerticalAlignmentConstantParser_Test - this is a slightly simpler verison of VerticalAlignmentConstantParserTest, perhaps wasn't meant to exist? passes
HorizontalAlignmentConstantParser_Test - follows the same pattern, passes

safehtml

storage

text

typedarrays

touch

safecss

resources

AtCharsetRuleStrippingTest - passes
GssResourceRTLTest - passes

regexp

place

module

media

logging

junit

RunStyleSeleniumTest

json

jsonp

http

geolocation

event

editor

dom

StyleTest - deliberately disabled with notes that it is more brittle than expected
ImageElementTest - passes

dev

EmmaClassLoadingTest - I believe this is legacy dev mode specific, may not be worth re-enabling, hasnt been included in a suite since they were introduced instead of running **/Test.class

dev.jjs

NoGenerateJsInteropExportsTest - FAILED - might be running incorrectly, needs a specific test run without exports enabled

core

ServerGwtBridgeTest - passes
GeneratorTest - passes
EntryTest - passes

codegen

cell

canvas

aria

activity

user.client

RandomTest - trivially passes, doesn't do anything. delete or do something useful?

user.client.ui

TextBoxTest/PasswordTextBoxTest - passes
LayoutPanelTest - FAILED testRedundantForceLayout fails a timeout, possibly htmlunit specific

user.client.runasync

CrossSiteLoadingStrategyForRunAsyncFailureTest - this is not actually a test at all

user.server.rpc

RPCTypeCheckArraysTest - FAILED, 3 failing tests. Two assertions inside the stream reader code, one failed test assertion. The failed test assertion appears to suggest that this has failed since it was first written in 2009, and so has never been run

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions