-
Notifications
You must be signed in to change notification settings - Fork 514
Prioritize PARALLEL_RAILS_ENV over the standard #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lib/parallel_tests/tasks.rb
Outdated
| class << self | ||
| def rails_env | ||
| 'test' | ||
| ENV['PARALLEL_RAILS_ENV'] || ENV['RAILS_ENV'] || 'test' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make this a non-breaking change:
| ENV['PARALLEL_RAILS_ENV'] || ENV['RAILS_ENV'] || 'test' | |
| ENV['PARALLEL_RAILS_ENV'] || 'test' |
RAILS_ENV could be get by running rake environment parallel:prepare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, the only option to set a different environment will be using PARALLEL_RAILS_ENV? RAILS_ENV will be discarded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah or we reopen #776
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, TBH I prefer the current solution implemented in this PR, but you are the parallel_tests maintainer (have a better overview of the gem project than me), so I can accept your suggestion and change the docs.
Probably I will need to pass PARALLEL_RAILS_ENV and RAILS_ENV in some situations, but at last it attends to my requirements (makes ParallelTests::Tasks.rails_env dynamic).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using RAILS_ENV looks like a good solution, but I'm pretty sure it would open up old gotchas again
and given that it has been so stable with the current solution I'm rather reluctant to risk that :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done c3b0bbf
|
5.4.0 🎉 fyi added the rails-env test back + fixed that it did not unset the env change |
Based on the debate on #970, makes
ParallelTests::Tasks.rails_envbe more dynamic being able to run on different Rails environments.The change prioritizes the
PARALLEL_RAILS_ENVvalue, if it isn't set, it defaults totest.Checklist
master(if not - rebase it).code introduces user-observable changes.