Refactor/axis labels and grid lines #24
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkyllonen
commented
Jan 16, 2026
Comment on lines
72
to
80
| <%!-- X-axis labels --%> | ||
| <.text | ||
| :for={date <- scale_values(@x_axis, ticks: 5)} | ||
| x={@x_axis[date]} | ||
| y={below_graph(@dimensions)} | ||
| dominant-baseline="hanging" | ||
| text-anchor="middle" | ||
| > | ||
| {Calendar.strftime(date, "%-m/%-d")} |
Collaborator
Author
There was a problem hiding this comment.
We still need to loop with a :for in order to render each different date label... so maybe we don't bother with our own text component since it's essentially the thinnest of wrappers around the SVG text element?
Collaborator
Author
There was a problem hiding this comment.
The helper library level can have an "x_label" component similar to what we have in Plox now that builds in some of these values to make it easier to plug-n-play?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.