Skip to content
This repository was archived by the owner on Nov 29, 2021. It is now read-only.

Conversation

@jjnicola
Copy link
Member

@jjnicola jjnicola commented Jan 26, 2021

What:
Always set end_time for interrupted scans.

Why:
end-time was set via set_scan_status (stopped). Now, the scan can be interrupted directly and the end time will be set.

How:
Interrupt a running scan and check with <get_scans="SCAN-ID"/>that the end_time is set.

Checklist:

@jjnicola jjnicola requested a review from bjoernricks as a code owner January 26, 2021 09:23
@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #353 (2c2c47d) into ospd-20.08 (12cda0d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           ospd-20.08     #353      +/-   ##
==============================================
- Coverage       73.91%   73.90%   -0.02%     
==============================================
  Files              23       23              
  Lines            2603     2602       -1     
==============================================
- Hits             1924     1923       -1     
  Misses            679      679              
Impacted Files Coverage Δ
ospd/ospd.py 71.64% <ø> (-0.05%) ⬇️
ospd/scan.py 92.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12cda0d...2c2c47d. Read the comment docs.

@jjnicola jjnicola changed the title End time Always set end_time for interrupted scans. Jan 26, 2021
@bjoernricks bjoernricks merged commit 60c6166 into greenbone:ospd-20.08 Jan 26, 2021
@jjnicola jjnicola deleted the end-time branch May 26, 2021 10:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants