Skip to content

Update the handling of the vts dictionary according to the new vts dictionary in a data manager. #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bjoernricks merged 8 commits into from
Dec 9, 2019
Merged

Update the handling of the vts dictionary according to the new vts dictionary in a data manager. #172

bjoernricks merged 8 commits into from
Dec 9, 2019

Conversation

@jjnicola
Copy link
Member

@jjnicola jjnicola commented Dec 6, 2019 •
edited
Loading

Depends on PR greenbone/ospd#191

@jjnicola jjnicola requested a review from bjoernricks as a code owner December 6, 2019 09:06
@codecov
Copy link

codecov bot commented Dec 6, 2019 •
edited
Loading

Codecov Report

Merging #172 into master will decrease coverage by 0.07%.
The diff coverage is 47.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
- Coverage   72.11%   72.04%   -0.08%     
==========================================
  Files           4        4              
  Lines        1040     1048       +8     
==========================================
+ Hits          750      755       +5     
- Misses        290      293       +3
Impacted Files Coverage Δ
ospd_openvas/daemon.py 60.27% <47.82%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ef991b...b6c0c96. Read the comment docs.

@jjnicola jjnicola added the Work in progress Waiting for Feature Specification validation. label Dec 6, 2019
@jjnicola jjnicola removed the Work in progress Waiting for Feature Specification validation. label Dec 9, 2019
@jjnicola
Set self.vts to None when there is a pending feed.
54ca597
@jjnicola
Update Test
1ce27f2
@jjnicola
Create a temporal deepcopy of the vts dictionary to start a scan.
0ab8828 
This avoid an expencive interprocess communication between the
scan process and the vts data manager, which reduce considerably
the time to load the plugins and their preferences in redis.
@jjnicola jjnicola added the Work in progress Waiting for Feature Specification validation. label Dec 9, 2019
@jjnicola
Make deepcopy of the vts dictionary when adding a result.
fad4427 
This avoids to consult the vts dictionary many times for each result,
which is expensive in terms of time specially when the scan has
many host details results.
@jjnicola jjnicola changed the title Set self.vts to None when there is a pending feed. Update the handling of the vts dictionary according to the new vts dictionary in a data manager. Dec 9, 2019
@bjoernricks bjoernricks merged commit 4ae552b into greenbone:master Dec 9, 2019
@jjnicola jjnicola removed the Work in progress Waiting for Feature Specification validation. label Dec 9, 2019
@jjnicola jjnicola deleted the mem-improve branch December 9, 2019 13:36
@jjnicola jjnicola mentioned this pull request Jan 14, 2020
Closed
ArnoStiefvater pushed a commit to ArnoStiefvater/ospd-openvas that referenced this pull request Oct 25, 2021
@bjoernricks
Merge pull request greenbone#172 from bjoernricks/update-black
037e572 
Update black
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jjnicola @bjoernricks