TypeScript for NvtFamiliesCommand and Alert commands #5057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsing from an empty element should behave (nearly) the same as creating a new instance. Therefore return undefined if specific sub elements are not available instead of creating default objects.
Also implement base tests for the Alert commands.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5057 +/- ##
==========================================
+ Coverage 75.74% 75.95% +0.20%
==========================================
Files 1137 1138 +1
Lines 29668 29651 -17
Branches 8893 8859 -34
==========================================
+ Hits 22471 22520 +49
+ Misses 6435 6372 -63
+ Partials 762 759 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
daniele-mng
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
TypeScript for NvtFamiliesCommand and Alert commands
Noe: AlertCommand needs some additional refactoring when the Alert UI parts are converted to TypeScript.
Why
Convert NvtFamiliesCommand and Alert commands to TypeScript.
References
https://jira.greenbone.net/browse/GEA-1098
Checklist