Skip to content

Conversation

@bjoernricks
Copy link
Contributor

What

Improve Credential Details

Why

  • Display sha256 fingerprint too
  • Improve layout of the table to align all displayed columns

Checklist

  • Tests

@github-actions
Copy link

github-actions bot commented Nov 28, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 74973f9.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.01%. Comparing base (cf1d54f) to head (74973f9).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4989      +/-   ##
==========================================
+ Coverage   69.98%   70.01%   +0.03%     
==========================================
  Files        1157     1158       +1     
  Lines      106979   106991      +12     
  Branches     8494     8496       +2     
==========================================
+ Hits        74867    74911      +44     
+ Misses      32072    32040      -32     
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjoernricks bjoernricks force-pushed the credential-details branch 2 times, most recently from d9eb171 to 6e270d6 Compare November 28, 2025 09:37
@bjoernricks bjoernricks marked this pull request as ready for review November 28, 2025 09:38
@bjoernricks bjoernricks requested a review from a team as a code owner November 28, 2025 09:38
Show the sha256 fingerprint of a client certificate at the credential
details.
Align the displayed data by defining the widths of the used table
columns.
@greenbonebot greenbonebot enabled auto-merge (rebase) November 28, 2025 12:12
@greenbonebot greenbonebot merged commit f5136a3 into main Nov 28, 2025
22 checks passed
@greenbonebot greenbonebot deleted the credential-details branch November 28, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants