Improve ScannerDialog #4986
Merged
Improve ScannerDialog #4986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
daniele-mng
previously approved these changes
Nov 27, 2025
bjoernricks
force-pushed
the
improve-scanner-dialog
branch
from
a67ccc2 to
8d4c2e3
Compare
* Allow to keep the type of an existing scanner even if the feature for the scanner type is not enabled. * Add placeholders for more fields * Allow to deselect and remove a scanner credential easily
bjoernricks
force-pushed
the
improve-scanner-dialog
branch
from
8d4c2e3 to
5f5d0bd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4986 +/- ##
==========================================
+ Coverage 69.97% 69.98% +0.01%
==========================================
Files 1157 1157
Lines 106948 106972 +24
Branches 8478 8493 +15
==========================================
+ Hits 74832 74860 +28
+ Misses 32076 32072 -4
Partials 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
daniele-mng
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improve ScannerDialog
Why
References
https://jira.greenbone.net/browse/GEA-1408
Checklist