Skip to content

Conversation

@bjoernricks
Copy link
Contributor

What

Fix binary report downloads

Why

Ensure the data is provided as binary data and no string encoding is applied by setting the expected response type correctly. Currently downloads for binary format like PDF are broken.

References

https://jira.greenbone.net/browse/GEA-1354

Checklist

  • Tests

Ensure the data is provided as binary data and no string encoding is
applied by setting the expected response type correctly.
@bjoernricks bjoernricks requested a review from a team as a code owner November 13, 2025 09:03
@github-actions
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 8508eca.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@greenbonebot greenbonebot enabled auto-merge (rebase) November 13, 2025 09:03
@greenbonebot greenbonebot merged commit ba59660 into main Nov 13, 2025
22 checks passed
@greenbonebot greenbonebot deleted the fix-report-download branch November 13, 2025 09:12
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.35%. Comparing base (610478b) to head (8508eca).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4953      +/-   ##
==========================================
+ Coverage   69.33%   69.35%   +0.02%     
==========================================
  Files        1147     1147              
  Lines      106781   106781              
  Branches     8323     8325       +2     
==========================================
+ Hits        74034    74056      +22     
+ Misses      32706    32684      -22     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cfi-gb
Copy link
Member

cfi-gb commented Nov 13, 2025

Also fixes greenbone/gvmd#2630 it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants