Skip to content

Conversation

@bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Nov 4, 2025

What

Display the number of critical results at the report list page.

Why

For CVSSv3 the critical severity level was introduced but the column for critical results was still missing at the report list page.

References

https://jira.greenbone.net/browse/GEA-1334

Checklist

  • Tests

@bjoernricks bjoernricks requested a review from a team as a code owner November 4, 2025 12:22
@greenbonebot greenbonebot enabled auto-merge (rebase) November 4, 2025 12:23
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 3222e51.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@bjoernricks bjoernricks marked this pull request as draft November 4, 2025 12:24
auto-merge was automatically disabled November 4, 2025 12:24

Pull request was converted to draft

@bjoernricks bjoernricks force-pushed the report-critical-results branch from f053715 to e7f1afa Compare November 4, 2025 12:32
@bjoernricks bjoernricks marked this pull request as ready for review November 4, 2025 12:32
@bjoernricks bjoernricks enabled auto-merge (rebase) November 4, 2025 12:33
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 39.13043% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.89%. Comparing base (5ca2cc1) to head (3222e51).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/web/pages/reports/ReportTable.tsx 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4925      +/-   ##
==========================================
- Coverage   68.90%   68.89%   -0.01%     
==========================================
  Files        1144     1144              
  Lines      106342   106365      +23     
  Branches     8111     8112       +1     
==========================================
+ Hits        73275    73284       +9     
- Misses      33026    33040      +14     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Add missing counts for critical results.
Show the counts of critical results at the report list page as a column.
@bjoernricks bjoernricks force-pushed the report-critical-results branch from e7f1afa to 3222e51 Compare November 5, 2025 07:10
@bjoernricks bjoernricks merged commit b920929 into main Nov 5, 2025
22 checks passed
@bjoernricks bjoernricks deleted the report-critical-results branch November 5, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants