Skip to content

Conversation

@andrew-w-ross
Copy link
Contributor

Adds common js as a workaround for packages of type module.

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR; I think this is an acceptable solution for now. Please format the code so that it passes linting 👍

yarn lint:fix

In future, please use the pull request template.

@andrew-w-ross andrew-w-ross requested a review from benjie July 27, 2022 17:00
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thanks! 🙌

@benjie benjie merged commit 09ccc7f into graphile:main Jul 28, 2022
@benjie
Copy link
Member

benjie commented Jul 28, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants