Implement comprehensive profile size limits across ingestion endpoints#4734
Merged
simonswine merged 13 commits intomainfrom Jan 9, 2026
Merged
Implement comprehensive profile size limits across ingestion endpoints#4734simonswine merged 13 commits intomainfrom
simonswine merged 13 commits intomainfrom
Conversation
This is aligned with existing usage of the limit in https://github.com/grafana/pyroscope/blob/76a701b54bff99ae594b969b5e4969d9661665c7/pkg/util/body/limit.go#L28-L28
Those limits are also applying post decompression, in order to be able to defend zip bombs.
simonswine
changed the title
simonswine
requested review from
a team,
aleks-p,
alsoba13,
bryanhuhta and
marcsanmi
as code owners
aleks-p
approved these changes
Jan 8, 2026
Contributor
aleks-p
left a comment
aleks-p
left a comment
There was a problem hiding this comment.
LGTM. Thanks for adding tests!
simonswine
added a commit
that referenced
this pull request
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements comprehensive size limit enforcement across all profile ingestion endpoints to protect against resource exhaustion from excessively large profiles and "gzip bomb" payloads.
Key Changes
RawFromBytesWithLimit()to enforce decompressed profile size limits, preventing small compressed payloads from expanding to huge sizesMaxProfileSizeBytesandIngestionBodyLimitBytesMaxSymbolSizeBytesconfiguration (default: 512MB) to limit symbol file sizes from debuginfodvalidation.DiscardedBytesandvalidation.DiscardedProfilesTesting
Added comprehensive test coverage for all endpoints including size limit enforcement scenarios.
Configuration
New flag:
--validation.symbolizer.max-symbol-size-bytes(default: 512MB)All limits are backwards compatible and only enforce when configured
> 0.