fix: tryFindGo doesn't trim repo path when absolute path is used#4608
Merged
simonswine merged 1 commit intomainfrom Nov 12, 2025
Merged
fix: tryFindGo doesn't trim repo path when absolute path is used#4608simonswine merged 1 commit intomainfrom
simonswine merged 1 commit intomainfrom
Conversation
When an absolute path is used like `/home/christian/github.com/grafana/pyroscope/[....]`, we are not matching the repository correctly and have to try quite a few files before we truncated enough folders. This change ensures that these cases are dealt with similar like a path starting with the repo name.
jake-kramer
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an absolute path is used like
/home/christian/github.com/grafana/pyroscope/[....], we are notmatching the repository correctly and have to try quite a few files
before we truncated enough folders.
This change ensures that these cases are dealt with similar like a path
starting with the repo name.