Skip to content

Add file type restriction to image upload input using accept attribute #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eternal-flame-AD merged 3 commits into from
Nov 5, 2025
Merged

Add file type restriction to image upload input using accept attribute #872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b75717
Add file type restriction to image upload input using accept attribute
LaurenceJJones Nov 5, 2025
fdaaa5a
Add dual validation: check both extension and MIME type
LaurenceJJones Nov 5, 2025
ca20541
align frontend and backend logic
eternal-flame-AD Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion api/application.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"net/http"
"os"
"path/filepath"
"strings"

"github.com/gin-gonic/gin"
"github.com/gotify/server/v2/auth"
Expand Down Expand Up @@ -459,7 +460,7 @@ func generateNonExistingImageName(imgDir string, gen func() string) string {
}

func ValidApplicationImageExt(ext string) bool {
switch ext {
switch strings.ToLower(ext) {
case ".gif", ".png", ".jpg", ".jpeg":
return true
default:
Expand Down
9 changes: 4 additions & 5 deletions ui/src/application/Applications.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ const Applications = observer(() => {

useEffect(() => void appStore.refresh(), []);

const validExtensions = ['.gif', '.png', '.jpg', '.jpeg'];

const handleImageUploadClick = (id: number) => {
uploadId.current = id;
if (fileInputRef.current) {
Expand All @@ -71,11 +73,7 @@ const Applications = observer(() => {
if (!file) {
return;
}
if (['image/png', 'image/jpeg', 'image/gif'].indexOf(file.type) !== -1) {
appStore.uploadImage(uploadId.current, file);
} else {
alert('Uploaded file must be of type png, jpeg or gif.');
}
appStore.uploadImage(uploadId.current, file);
};

return (
Expand Down Expand Up @@ -128,6 +126,7 @@ const Applications = observer(() => {
<input
ref={fileInputRef}
type="file"
accept={validExtensions.join(',')}
style={{display: 'none'}}
onChange={onUploadImage}
/>
Expand Down
Loading