Skip to content

Conversation

@grantdfoster
Copy link
Collaborator

What

Needed to point job signature to teetypes.Job due to integration w/ indexer

@grantdfoster grantdfoster requested review from Copilot, mcamou and mudler and removed request for Copilot September 24, 2025 00:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the job signature to use teetypes.Job from the external tee-types package instead of the internal types.Job for better integration with the indexer.

  • Updated the CreateJobSignature method signature to accept teetypes.Job instead of types.Job
  • Replaced all test instances using the old job type with the new external type
  • Added necessary import for teetypes package and removed unused internal types import

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pkg/client/http.go Updated CreateJobSignature method signature to use teetypes.Job
pkg/client/http_test.go Updated test to use teetypes.Job and added required import
internal/api/api_test.go Replaced all job instantiations with teetypes.Job and cleaned up unused import

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@rapidfix rapidfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we decided to start using the tee-worker for the types?

@grantdfoster grantdfoster merged commit cbb35d3 into main Sep 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants