Refactor the configuration #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantdfoster
reviewed
Sep 3, 2025
grantdfoster
reviewed
Sep 3, 2025
grantdfoster
reviewed
Sep 3, 2025
grantdfoster
reviewed
Sep 3, 2025
grantdfoster
approved these changes
Sep 3, 2025
grantdfoster
reviewed
Sep 3, 2025
Collaborator
grantdfoster
left a comment
grantdfoster
left a comment
There was a problem hiding this comment.
looks great, I love OCD at work! just a few non-blocking notes/comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This refactors the configuration to eliminate duplication between
config.goandconfig/config.go, and also to centralize most of theos.GetenvcallsWHY
In preparation for modifying the log level at runtime and moving to structured config.