add support for subfields in field masks #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
==========================================
+ Coverage 88.22% 89.57% +1.35%
==========================================
Files 12 12
Lines 620 614 -6
==========================================
+ Hits 547 550 +3
+ Misses 73 64 -9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
=======================================
Coverage 89.67% 89.67%
=======================================
Files 12 12
Lines 620 620
=======================================
Hits 556 556
Misses 64 64
Continue to review full report at Codecov.
|
jpoehnelt
force-pushed
the
fix/subfields_support
branch
from
d807276 to
1044844
Compare
googlebot
added
the
cla: yes
jpoehnelt
changed the title
Contributor
Author
|
@amuramoto sorry for all the formatting in the diff. only changes were the list of values and the tests with a subfield |
jpoehnelt
added
triage me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #268
This causes issues regarding what is the source of truth. I would prefer to default to the API to handle this which returns the follow error to the user.