Skip to content

Conversation

@emmileaf
Copy link
Contributor

Similar to #951: updates copyright year in generated license headers to 2023 (for new files):

  • Template string change in CommentComposer.java
  • Golden file updates in unit/integration/showcase tests

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 29, 2023
@emmileaf emmileaf marked this pull request as ready for review May 29, 2023 14:53
@emmileaf emmileaf requested a review from a team as a code owner May 29, 2023 14:53
@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@emmileaf emmileaf added the owlbot:run Add this label to trigger the Owlbot post processor. label May 29, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 29, 2023
@blakeli0
Copy link
Contributor

CC: @suztomo This is what I meant that the generator generates license headers, but not to the protoc generated files. I guess we need to update owlbot to 2023 somewhere? Because I see that the newly generated client still have 2022, like this.

@suztomo
Copy link
Member

suztomo commented May 30, 2023

@emmileaf
Copy link
Contributor Author

Oh, I see the corresponding 2020 year in generated proto- and grpc- classes: e.g. RapidMigrationAssessmentGrpc.java; Annotation.java.

Will merge this PR and follow-up separately with the fix in synthtool repo. Thanks @blakeli0 and @suztomo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants