Skip to content

Conversation

@athakor
Copy link
Contributor

@athakor athakor commented May 25, 2020

Fixes #332

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 25, 2020
@athakor athakor requested review from frankyn and jkwlui May 25, 2020 07:45
@frankyn frankyn requested a review from JesseLovelace May 26, 2020 15:00
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @athakor, added @JesseLovelace as well.

Linkage monitor failure needs to be addressed and request for method documentation.

@frankyn frankyn added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 26, 2020
@athakor athakor added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels May 28, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 28, 2020
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2020
@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #335 into master will increase coverage by 0.36%.
The diff coverage is 68.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #335      +/-   ##
============================================
+ Coverage     63.29%   63.66%   +0.36%     
  Complexity      613      613              
============================================
  Files            32       32              
  Lines          5144     5166      +22     
  Branches        492      495       +3     
============================================
+ Hits           3256     3289      +33     
+ Misses         1724     1718       -6     
+ Partials        164      159       -5     
Impacted Files Coverage Δ Complexity Δ
...main/java/com/google/cloud/storage/BucketInfo.java 84.39% <68.00%> (+2.38%) 86.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edfd1e6...8491593. Read the comment docs.

@athakor athakor added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 25, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 25, 2020
@athakor
Copy link
Contributor Author

athakor commented Jun 26, 2020

Linkage monitor failure needs to be addressed and request for method documentation.

@frankyn done PTAL

@frankyn
Copy link
Contributor

frankyn commented Jun 26, 2020

We are still blocked and pending approval to move forward from @jkwlui

@athakor athakor added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 25, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 25, 2020
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2020
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @athakor,

Update: The Cloud Storage team has updated type of noncurrent_time_before and custom_time to be a Date format (YYYY-mm-dd) instead of DateTime.

Discovery document with updated documentation with respect to these fields:
https://www.googleapis.com/discovery/v1/apis/storage/v1/rest

This has been updated in the latest release dependency in PR (#457). Please update relevant documentation.

@athakor
Copy link
Contributor Author

athakor commented Aug 13, 2020

Hi @athakor,

Update: The Cloud Storage team has updated type of noncurrent_time_before and custom_time to be a Date format (YYYY-mm-dd) instead of DateTime.

Discovery document with updated documentation with respect to these fields:
https://www.googleapis.com/discovery/v1/apis/storage/v1/rest

This has been updated in the latest release dependency in PR (#457). Please update relevant documentation.

@frankyn That change has been already done also updated the relevant java doc.

@frankyn frankyn removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 24, 2020
@athakor
Copy link
Contributor Author

athakor commented Aug 26, 2020

@jkwlui @JesseLovelace PTAL

@frankyn frankyn merged commit 1e3e88a into googleapis:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support daysSinceNoncurrentTime and noncurrentTimeBefore OLM options

4 participants