-
Notifications
You must be signed in to change notification settings - Fork 87
feat: add @BetaApi BlobWriteSession#parallelCompositeUpload #2239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2008803
feat: add @BetaApi BlobWriteSession#parallelCompositeUpload
BenWhitehead 07cb76c
docs: add since javadoc to all new public surface
BenWhitehead 48428b1
docs: javadocs cleanup 2
BenWhitehead 07d5258
chore: user-project for readAllBytes
BenWhitehead File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we draw attention to this section. maybe with a heading like drawbacks or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #2242 I'm reordering the columns to move this column of the table more left to make it more prominent.
Because this text is in a table we can't really add a heading to it. Secondarily, since the table is already struggling with horizontal space on cloud.google.com[1] I don't know that adding another column would surface it better or get it hidden more.
[1] https://cloud.google.com/java/docs/reference/google-cloud-storage/latest/com.google.cloud.storage#blobwritesessionconfigs