test: introduce KmsFixture #1823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new KmsFixture class to encapsulate and pull the lifecycle of the Kms KeyRing and Keys up into the registry. Remove all KMS/IAM related setup from ITKmsTest in favor of the new Fixture. Drop use of grpc stubs directly in favor of the GAPIC client for KMS.
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
the
api: storage
frankyn
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
KmsFixtureclass to encapsulate and pull the lifecycle of the KmsKeyRingandKeysup into the Registry.Remove all KMS/IAM related setup from ITKmsTest in favor of the new Fixture.
Drop use of grpc stubs directly in favor of the GAPIC client for KMS.
Cleanup of TODO from #1785