test(storage): fix unauthenticated access tests #3806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests rely on public data in the Landsat bucket (https://cloud.google.com/storage/docs/public-datasets/landsat). The data under PRE/ has been removed, so I shifted these to instead use another prefix which should be stable. Already done for dotnet here: googleapis/google-cloud-dotnet#6025 Fixes googleapis#3800 Fixes googleapis#3801
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: storage
BenWhitehead
added a commit
to googleapis/java-storage
that referenced
this pull request
Mar 16, 2021
…nloadPublicBlobWithoutAuthentication (#759) Port of googleapis/google-cloud-go#3806 Fixes #755
BenWhitehead
added a commit
to googleapis/java-storage
that referenced
this pull request
May 11, 2021
…nloadPublicBlobWithoutAuthentication (#759) (#817) Port of googleapis/google-cloud-go#3806 Fixes #755 cherry-pick from 9a6619c
BenWhitehead
added a commit
to googleapis/java-storage
that referenced
this pull request
May 11, 2021
…nloadPublicBlobWithoutAuthentication (#759) (#818) Port of googleapis/google-cloud-go#3806 Fixes #755 cherry-pick from 9a6619c
danielduhh
pushed a commit
to danielduhh/java-storage
that referenced
this pull request
Jun 9, 2021
…nloadPublicBlobWithoutAuthentication (googleapis#759) Port of googleapis/google-cloud-go#3806 Fixes googleapis#755
danielduhh
added a commit
to googleapis/java-storage
that referenced
this pull request
Jun 10, 2021
* build: add kokoro & ci changes * add samples folder to pass ci * build: pin fmt-maven-plugin version to 2.9 fmt-maven-plugin v2.10 is compiled for java 11, v2.9 is compiled for java 8 port of fix from googleapis/java-shared-config#90 * remove samples directory & ci * add ci block * remove snippet bot config * sync ci changes * fix(test): update blob paths used in storage.it.ITStorageTest#testDownloadPublicBlobWithoutAuthentication (#759) Port of googleapis/google-cloud-go#3806 Fixes #755 Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
danielduhh
pushed a commit
to googleapis/java-storage
that referenced
this pull request
Jun 17, 2021
…nloadPublicBlobWithoutAuthentication (#759) Port of googleapis/google-cloud-go#3806 Fixes #755
danielduhh
added a commit
to googleapis/java-storage
that referenced
this pull request
Jun 17, 2021
* feat: configure initial sp version * fix(test): update blob paths used in storage.it.ITStorageTest#testDownloadPublicBlobWithoutAuthentication (#759) Port of googleapis/google-cloud-go#3806 Fixes #755 * test: remove error string matching (#861) It looks like the text for this error on the backend has changed (sometimes) from "Precondition Failed" to "At least one of the pre-conditions you specified did not hold". I don't think it's really necessary to check the exact message in any case given that we do check for a code of 412, which implies a precondition failure. I added a check of the error Reason instead, which is more standardized. Fixes #853 Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com> Co-authored-by: Chris Cotter <cjcotter@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests rely on public data in the Landsat bucket
(https://cloud.google.com/storage/docs/public-datasets/landsat).
The data under PRE/ has been removed, so I shifted these to instead
use another prefix which should be stable.
Already done for dotnet here: googleapis/google-cloud-dotnet#6025
Fixes #3800
Fixes #3801