-
Notifications
You must be signed in to change notification settings - Fork 138
Suppress deprecation warnings in generated code #2797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Our derives now properly emit `#[allow(deprecated)]` in all locations where user code might be referenced, suppressing warnings when deriving traits on deprecated types. This change adds regression tests for `ByteHash`, `ByteEq`, and `SplitAt` (and implicitly `KnownLayout` via `SplitAt`) to ensure this behavior is preserved. It also fixes missing suppressions in `KnownLayout`'s internal helpers (`Field` impls and `__ZerocopyKnownLayoutMaybeUninit` struct).
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2797 +/- ##
=======================================
Coverage 88.14% 88.14%
=======================================
Files 20 20
Lines 5450 5450
=======================================
Hits 4804 4804
Misses 646 646 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Our derives now properly emit `#[allow(deprecated)]` in all locations where user code might be referenced, suppressing warnings when deriving traits on deprecated types. This change adds regression tests for `ByteHash`, `ByteEq`, and `SplitAt` (and implicitly `KnownLayout` via `SplitAt`) to ensure this behavior is preserved. It also fixes missing suppressions in `KnownLayout`'s internal helpers (`Field` impls and `__ZerocopyKnownLayoutMaybeUninit` struct).
Our derives now properly emit `#[allow(deprecated)]` in all locations where user code might be referenced, suppressing warnings when deriving traits on deprecated types. This change adds regression tests for `ByteHash`, `ByteEq`, and `SplitAt` (and implicitly `KnownLayout` via `SplitAt`) to ensure this behavior is preserved. It also fixes missing suppressions in `KnownLayout`'s internal helpers (`Field` impls and `__ZerocopyKnownLayoutMaybeUninit` struct).
Fixes an issue where deriving zerocopy traits on deprecated structs would emit warnings about "use of deprecated item".
This PR adds
#[allow(deprecated)]to:derive_known_layout'sFieldimplementations.derive_known_layout's internalMaybeUninitstruct.derive_known_layout'sKnownLayoutimpl for the internal struct.derive_hashimplementation (was missing).derive_eqimplementation (was missing).It also adds regression tests in
zerocopy-derive/tests/deprecated.rswhich define deprecated types and derive various traits, ensuring no warnings are emitted (the tests have#![deny(deprecated)]).Closes #553
PR created automatically by Jules for task 3723672898041436653 started by @joshlf