Deny clippy::multiple_unsafe_ops_per_block #2781
Conversation
This commit ensures that we don't add new unsafe blocks that fail the `clippy::multiple_unsafe_ops_per_block` lint. It adds `#[allow(clippy::multiple_unsafe_ops_per_block)]` to existing failures to allow us to iteratively burn them down later. It also fixes a `clippy::undocumented_unsafe_blocks` failure in `src/util/mod.rs` by moving the safety comment closer to the unsafe block.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This commit ensures that we don't add new unsafe blocks that fail the `clippy::multiple_unsafe_ops_per_block` lint. It adds `#[allow(clippy::multiple_unsafe_ops_per_block)]` to existing failures to allow us to iteratively burn them down later. It also fixes a `clippy::undocumented_unsafe_blocks` failure in `src/util/mod.rs` by moving the safety comment closer to the unsafe block.
This commit ensures that we don't add new unsafe blocks that fail the `clippy::multiple_unsafe_ops_per_block` lint. It adds `#[allow(clippy::multiple_unsafe_ops_per_block)]` to existing failures to allow us to iteratively burn them down later. It also fixes a `clippy::undocumented_unsafe_blocks` failure in `src/util/mod.rs` by moving the safety comment closer to the unsafe block.
This commit ensures that we don't add new unsafe blocks that fail the `clippy::multiple_unsafe_ops_per_block` lint. It adds `#[allow(clippy::multiple_unsafe_ops_per_block)]` to existing failures to allow us to iteratively burn them down later. It also fixes a `clippy::undocumented_unsafe_blocks` failure in `src/util/mod.rs` by moving the safety comment closer to the unsafe block.
This commit ensures that we don't add new unsafe blocks that fail the `clippy::multiple_unsafe_ops_per_block` lint. It adds `#[allow(clippy::multiple_unsafe_ops_per_block)]` to existing failures to allow us to iteratively burn them down later. It also fixes a `clippy::undocumented_unsafe_blocks` failure in `src/util/mod.rs` by moving the safety comment closer to the unsafe block.
joshlf
force-pushed
the
clippy-multiple-unsafe-ops
branch
from
0fa60ce to
9868a66
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2781 +/- ##
=======================================
Coverage 88.14% 88.14%
=======================================
Files 20 20
Lines 5450 5450
=======================================
Hits 4804 4804
Misses 646 646 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 participants
Deny clippy::multiple_unsafe_ops_per_block and address failures.
PR created automatically by Jules for task 17859878309406227831 started by @joshlf