[derive] IntoBytes padding error says number of bytes
#2699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
padding-error-message
branch
from
a6141d6 to
a558df4
Compare
Member
Author
|
@jswrenn Since we support unions and enums, perhaps we should just say "padding" instead of "inter-field padding"? Structs and enums can have trailing padding too, while unions can only have trailing padding. EDIT: I'm just going to go ahead and make that change. Lmk if you think we should keep the old wording and I can revert. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2699 +/- ##
=======================================
Coverage 88.75% 88.75%
=======================================
Files 20 20
Lines 5343 5343
=======================================
Hits 4742 4742
Misses 601 601 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
While we're here, always say "padding" instead of "inter-field padding", as all kinds (structs, enums, and unions) can have trailing padding too. As an example, the diff for `zerocopy-derive/tests/ui-stable/enum.stderr` contains: -error[E0277]: `IntoBytes3` has inter-field padding +error[E0277]: `IntoBytes3` has 2 total byte(s) of padding Closes #1717
joshlf
force-pushed
the
padding-error-message
branch
from
a558df4 to
ea806e0
Compare
joshlf
changed the title
IntoBytes padding error says number of bytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we're here, always say "padding" instead of "inter-field padding",
as all kinds (structs, enums, and unions) can have trailing padding too.
As an example, the diff for
zerocopy-derive/tests/ui-stable/enum.stderrcontains:-error[E0277]:
IntoBytes3has inter-field padding+error[E0277]:
IntoBytes3has 2 total byte(s) of paddingCloses #1717