-
Notifications
You must be signed in to change notification settings - Fork 138
derive(IntoBytes): support repr(C) structs with explicit trailing slices
#2679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
297e9c7 to
3019270
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2679 +/- ##
==========================================
+ Coverage 88.75% 88.91% +0.16%
==========================================
Files 20 20
Lines 5343 5422 +79
==========================================
+ Hits 4742 4821 +79
Misses 601 601 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshlf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wooo!!!
Can you add UI tests that succeed but wouldn't have succeeded before this change? We may also want some new failure ones to make sure we're properly exercising the edge cases of our logic (namely, what if you have a non-syntactically-DST-but-actually-DST repr(C) type? What about a syntactically-DST non-repr(C) type? etc).
3019270 to
07fd645
Compare
|
2ed022c to
147274b
Compare
02d5558 to
f352020
Compare
… slices
For example:
#[repr(C)]
struct Example {
leading: u8,
trailing: [Trailing]
}
Makes progress towards #1112
f352020 to
33c3fd7
Compare
For example:
Makes progress towards #1112