Skip to content

Conversation

@jswrenn
Copy link
Collaborator

@jswrenn jswrenn commented Aug 15, 2025

For example:

#[repr(C)]
struct Example {
    leading: u8,
    trailing: [Trailing]
}

Makes progress towards #1112

@jswrenn jswrenn requested a review from joshlf August 15, 2025 17:06
@jswrenn jswrenn force-pushed the derive-intobytes-reprc branch 2 times, most recently from 297e9c7 to 3019270 Compare August 15, 2025 18:23
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 98.50746% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.91%. Comparing base (3d35f06) to head (33c3fd7).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/layout.rs 97.46% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2679      +/-   ##
==========================================
+ Coverage   88.75%   88.91%   +0.16%     
==========================================
  Files          20       20              
  Lines        5343     5422      +79     
==========================================
+ Hits         4742     4821      +79     
  Misses        601      601              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@joshlf joshlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooo!!!

Can you add UI tests that succeed but wouldn't have succeeded before this change? We may also want some new failure ones to make sure we're properly exercising the edge cases of our logic (namely, what if you have a non-syntactically-DST-but-actually-DST repr(C) type? What about a syntactically-DST non-repr(C) type? etc).

@jswrenn jswrenn force-pushed the derive-intobytes-reprc branch from 3019270 to 07fd645 Compare August 26, 2025 17:44
@jswrenn
Copy link
Collaborator Author

jswrenn commented Aug 26, 2025

Can you add UI tests that succeed but wouldn't have succeeded before this change? We may also want some new failure ones to make sure we're properly exercising the edge cases of our logic (namely, what if you have a non-syntactically-DST-but-actually-DST repr(C) type? What about a syntactically-DST non-repr(C) type? etc).

Done

@jswrenn jswrenn force-pushed the derive-intobytes-reprc branch 3 times, most recently from 2ed022c to 147274b Compare August 29, 2025 15:30
@joshlf joshlf force-pushed the derive-intobytes-reprc branch 9 times, most recently from 02d5558 to f352020 Compare September 6, 2025 21:00
… slices

For example:

    #[repr(C)]
    struct Example {
        leading: u8,
        trailing: [Trailing]
    }

Makes progress towards #1112
@joshlf joshlf force-pushed the derive-intobytes-reprc branch from f352020 to 33c3fd7 Compare September 6, 2025 21:09
@joshlf joshlf enabled auto-merge September 6, 2025 21:18
@joshlf joshlf added this pull request to the merge queue Sep 6, 2025
Merged via the queue into main with commit a55463e Sep 6, 2025
89 checks passed
@joshlf joshlf deleted the derive-intobytes-reprc branch September 6, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants