Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Revert back to C++17 for now #1246

Merged
mlw merged 1 commit into from
Nov 30, 2023
Merged

Revert back to C++17 for now #1246

mlw merged 1 commit into from
Nov 30, 2023

Conversation

@mlw
Copy link
Contributor

@mlw mlw commented Nov 30, 2023

Due to internal reasons, we need to continue on C++17 for now.

@mlw mlw added the build label Nov 30, 2023
@mlw mlw added this to the 2023.10 Release milestone Nov 30, 2023
@mlw mlw requested a review from a team as a code owner November 30, 2023 02:22
pmarkowsky
pmarkowsky approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mlw mlw merged commit 2b5d557 into google:main Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@russellhancox russellhancox russellhancox approved these changes

@pmarkowsky pmarkowsky pmarkowsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build

Projects

None yet

Milestone

2023.10 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@mlw @russellhancox @pmarkowsky