Skip to content

Update .travis.yml#963

Merged
cdata merged 2 commits intomasterfrom
fix-travis-chrome
Jan 16, 2020
Merged

Update .travis.yml#963
cdata merged 2 commits intomasterfrom
fix-travis-chrome

Conversation

@cdata
Copy link
Contributor

@cdata cdata commented Jan 16, 2020

This switches us back to an old way of pulling a Chrome binary into our Travis build. My recollection is that we stopped doing this on purpose. Hopefully that's not true.

Keying off of corresponding change in lit-element project: lit/lit-element#876

@cdata cdata requested a review from elalish January 16, 2020 17:13
Copy link
Contributor

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build's running more than 30 seconds, so that's a good sign!

@cdata cdata merged commit b3dae2b into master Jan 16, 2020
elalish pushed a commit to elalish/model-viewer that referenced this pull request Feb 4, 2020
 
Update .travis.yml (google#963)

* Update .travis.yml

* Update .travis.yml
@cdata cdata added this to the v0.9.0 milestone Feb 11, 2020
@cdata cdata deleted the fix-travis-chrome branch February 11, 2020 20:02
@cdata cdata self-assigned this Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants