'animal-sniffer-maven-plugin' changes: version is upgraded and extracted into root pom.xml

[dejan2609]

Note: this is a maven build improvement.

Details:

• plugin version is upgraded: 1.15 -->> 1.17
• plugin version is removed out of submodules into root pom.xml (i.e. plugin version can be changed easily)

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[dejan2609]

I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[dejan2609]

@penmetsaa, @kkeshava, @rohininidhi, @AlipmanG: please review.

[penmetsaa]

@dejan2609 ,
Thank you for contributing to libphonenumber!
Sorry for the delay in reviewing this PR. Yes, it is good to have plugin's version numbers at one place, parent level. Added few comments. Please make the updated accordingly.

@lararennie,
I have tried my suggested edits also of this PR and we were able run all mvn release commands successfully, but are we missing out any use case for which we made the plugin version numbers at component level? Also please provide your inputs on the changes and my comments. Thanks :)

[dejan2609]

New commit pushed in order to apply suggestions made by @penmetsaa (let me know if you want me to squash/force push commits at some point).

I have some maven-release-plugin related experience, lmk if I can help you with that also.

[lararennie]

@dejan2609 ,
Thank you for contributing to libphonenumber!
Sorry for the delay in reviewing this PR. Yes, it is good to have plugin's version numbers at one place, parent level. Added few comments. Please make the updated accordingly.

@lararennie,
I have tried my suggested edits also of this PR and we were able run all mvn release commands successfully, but are we missing out any use case for which we made the plugin version numbers at component level? Also please provide your inputs on the changes and my comments. Thanks :)

I don't know of any reason why we did it there,

@dejan2609 ,
Thank you for contributing to libphonenumber!
Sorry for the delay in reviewing this PR. Yes, it is good to have plugin's version numbers at one place, parent level. Added few comments. Please make the updated accordingly.

@lararennie,
I have tried my suggested edits also of this PR and we were able run all mvn release commands successfully, but are we missing out any use case for which we made the plugin version numbers at component level? Also please provide your inputs on the changes and my comments. Thanks :)

I don't know of any reason why we made it there, I definitely am not a maven expert so if it works and you don't get any new warnings because of it then LGTM :)

[lararennie]

Also: typically we squash on commit, yes.

[penmetsaa]

@dejan2609,
Thanks for offering help on "maven-release-plugin" aswell. If you would like to add some more edits w.r.t that, please make it. As we do not have expertise on MVN to review the changes, request you to make the edits (obvious ones) with more notes/details attached to it :) Also, please avoid changes that might cause issues as we are not trying to be here.

As we are in between of the release 8.9.13, we would like to approve this PR by end of tomorrow.

[dejan2609]

Here you go @penmetsaa and @lararennie (squash/rebase onto master is done).

Also, I will definitely try to hack some maven related stuff (and will provide details/rationale for each case).

[penmetsaa]

@dejan2609,
Thanks for being patient. As release is done, you can now pull the updates and merge your commits to master.

If you are not able to, we will do the merge action. Thanks for all your contribution :)

[dejan2609]

@penmetsaa thanx for approval ! I don't see a merge button or anything like that, so I guess that only owners have enough rights for that; feel free to merge it anytime.

[dejan2609]

Aha, I think I get it now.... I performed local rebase and force push and by doing that I missed the chance to update my branch in a GitHub-friendly way (now I assume that button "Update branch" would trigger merging automatically, given a fact that changes were approved).

@penmetsaa please merge it on your end. Thanx !

[penmetsaa]

@dejan2609
Done. Thanks :)