Attempt to fix Python setup.py build for clang / MacOS #1211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbartholomew
force-pushed
the
macos-python
branch
from
b9249f5 to
1ffcd4d
Compare
Collaborator
Author
|
@mauvilsa if you have time, could you try this on mac? |
|
@johnbartholomew it works, see https://github.com/omni-us/jsonargparse/pull/682/checks. Thanks for the fix! |
mauvilsa
approved these changes
Feb 24, 2025
setup.py test is deprecated, just run the tests directly. Require setuptools 72.2 - this incorporates upstream distutils changes which make it easier to adjust C++ compile flags independently of C compile flags.
johnbartholomew
force-pushed
the
macos-python
branch
from
1ffcd4d to
dabbcc8
Compare
Collaborator
Author
|
Merged, but slightly accidentally (I mixed up two branches I was working on - oops!). Although I had to remove it from this PR the actual relevant commit is in master as commit a679ce4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang is apparently more strict about using
-std=c++17only for C++ compilation, rejecting it with an error for C compilation (GCC gives a warning but proceeds).This is an attempt to fix #1202.