Skip to content

Conversation

@vergenzt
Copy link
Contributor

@vergenzt vergenzt commented Oct 11, 2024

Resolves #289!

Was pretty easy to add as you can see. 🙂

Let me know if you have any concerns or feedback!

Only part I'm not sure of is the changes to doc/third_party/MathJax-2.7.2/unpacked -- it looks like like at

<script type="text/javascript" src="/third_party/MathJax-2.7.2/MathJax.js"></script>
we link to the root "packed" version of MathJax.js, but I can't figure out to re-"pack" the unpacked code. 🤔 I'm also not sure how critical it is though. 🤷🏻‍♂️

Note: I'm working on a companion PR to google/go-jsonnet too.

@google-cla
Copy link

google-cla bot commented Oct 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@vergenzt
Copy link
Contributor Author

Any updates? Anybody willing to review this and weigh in?

@betabandido
Copy link

Is there any estimate on when this will get merged (and released)?

@johnbartholomew
Copy link
Collaborator

Hi. Thanks for your contribution, and sorry for the delay in processing it!

Copy link
Collaborator

@johnbartholomew johnbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MathJax change is not needed - that operator list is nothing to do with jsonnet, so it shouldn't be updated for this change. As far as I can tell, those operators originate from the MathML spec - https://www.w3.org/TR/MathML/appendixc.html (the existing triple-pipe fence was added to the table in mathjax/MathJax@bf862f6#diff-8e4e61c67ba8f00ac92875cb211f3a2ec8eef705f71d232d4d3dcb014d0517c0)

The optable in the MathJax code is not related to Jsonnet's syntax, and
should not have `|||-` added.
@johnbartholomew johnbartholomew merged commit 5a4e8e3 into google:master Jan 20, 2025
6 checks passed
johnbartholomew pushed a commit to johnbartholomew/go-jsonnet that referenced this pull request Jan 20, 2025
johnbartholomew pushed a commit to johnbartholomew/go-jsonnet that referenced this pull request Jan 20, 2025
johnbartholomew pushed a commit to google/go-jsonnet that referenced this pull request Jan 20, 2025
@vergenzt
Copy link
Contributor Author

The MathJax change is not needed - that operator list is nothing to do with jsonnet, so it shouldn't be updated for this change. As far as I can tell, those operators originate from the MathML spec - https://www.w3.org/TR/MathML/appendixc.html (the existing triple-pipe fence was added to the table in mathjax/MathJax@bf862f6#diff-8e4e61c67ba8f00ac92875cb211f3a2ec8eef705f71d232d4d3dcb014d0517c0)

Yay thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support |||- from YAML

4 participants