Add source archive and snippet to release #1089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like Github Actions already had the permissions. This doesn't change our release process I guess then. It will just automatically create this additional artifact and we don't have to worry about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sparkprime ref my comment in #1083, BCR requires that a stable source archive is added to the release. I cribbed this from rules_python, and edited the snippet it generates a bit. Here's an example of what it generates:
https://github.com/mortenmj/jsonnet/releases/tag/v0.21.0
I have no real opinions on what text this release snippet should contain, if anything.
Here's a full example from rules_python: https://github.com/bazelbuild/rules_python/releases/tag/0.22.0
I had to grant GitHub Actions read/write permissions to the repo for this to work. It's in "Workflow permissions" under Settings -> Actions -> General.