Fix test_poly_mul to be compatible with NumPy 2. The issue is recasting float64 to int32. jnp.int32() seems to be rounding down overflows to signed_int32.MAX and signed_int32.MIN. #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_673927772
branch
from
1ec685f to
536d45a
Compare
…ng float64 to int32. jnp.int32() seems to be rounding down overflows to signed_int32.MAX and signed_int32.MIN. PiperOrigin-RevId: 675184853
copybara-service
bot
force-pushed
the
test_673927772
branch
from
536d45a to
d5f3f09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test_poly_mul to be compatible with NumPy 2. The issue is recasting float64 to int32. jnp.int32() seems to be rounding down overflows to signed_int32.MAX and signed_int32.MIN.