Fix CMake broken option gtest_force_shared_crt #4877
+12
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathstuf
reviewed
Nov 26, 2025
charles-lunarg
force-pushed
the
fix_CMake_option_gtest_force_shared_crt
branch
2 times, most recently
from
96a33a9 to
572b384
Compare
With CMake 3.15, a new mechanism was added to control which CRT libraries link to. Because the minimum CMake version is above 3.15, googletest can leverage it in the implementation of gtest_force_shared_crt. If CMAKE_MSVC_RUNTIME_LIBRARY is already defined, googletest will respect its value rather than replace it, allowing for users to customize the exact CRT used by googletest.
charles-lunarg
force-pushed
the
fix_CMake_option_gtest_force_shared_crt
branch
from
572b384 to
0b65649
Compare
mathstuf
reviewed
Dec 8, 2025
mathstuf
left a comment
mathstuf
left a comment
There was a problem hiding this comment.
I approve (but lack permissions to express it through Github's review mechanisms).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake 3.15 added MSVC_RUNTIME_LIBRARY, an official mechanism to configure the runtime library used by targets. Setting the property will properly set the MSVC runtime library regardless of the values in the compiler flags variables.
Fixes #4731